Skip to content

[Types] Inline LuaCATS busted+luassert type annotations#7438

Open
keithharvey wants to merge 1 commit into
beyond-all-reason:fmtfrom
keithharvey:mig-busted-types
Open

[Types] Inline LuaCATS busted+luassert type annotations#7438
keithharvey wants to merge 1 commit into
beyond-all-reason:fmtfrom
keithharvey:mig-busted-types

Conversation

@keithharvey

@keithharvey keithharvey commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Part of BAR type-error cleanup. Rebuilds idempotently from master via just bar::fmt-mig-generate.

What it does: Hand-curated (not a codemod): vendors LuaCATS/busted and LuaCATS/luassert type annotations under types/busted/ and types/luassert/.

# busted-types - vendor LuaCATS busted + luassert type annotations under
# types/busted and types/luassert with per-directory provenance.md. Carried-
# commit leaf — no codemod; curated branch holds the hand-authored commit.

Waits on lumen-oss/lux#953 to replace with a Lux dev-dep declaration.

Branch Topology

All branches in the BAR type-error cleanup stack. Regenerated deterministically by just bar::fmt-mig-generate. Generated 2026-07-17 07:18:48 UTC.

Leaves — each targets master, mergeable independently:

Branch Command Diff vs parent Units
fmt stylua 1376 files, +179088 −184017 ✅ pass
mig-bracket bar-lua-codemod bracket-to-dot 338 files, +7645 −7645 ✅ pass
mig-rename-aliases bar-lua-codemod rename-aliases 175 files, +377 −377 ✅ pass
mig-detach-bar-modules bar-lua-codemod detach-bar-modules 178 files, +1694 −1565 ✅ pass
mig-integration-tests <hand curated> 20 files, +134 −81 ✅ pass
mig-busted-types ← you are here <hand curated> 12 files, +1501 −0 ✅ pass

Rollups — composite branches stacking the leaves and (for fmt-llm) the env + LLM layers:

Branch What it is Diff vs master Diff vs parent Units
mig all deterministic transforms combined; rebuilds from master 1400 files, +183338 −186584 512 files, +11305 −9622 ✅ pass
fmt-llm-source human-curated env layer (.emmyrc.json, types/* stubs, CI gate) + manual fixes that drive type errors to 0 in concert with the LLM pass 1405 files, +183806 −186746 61 files, +522 −216 ✅ pass
fmt-llm fmt-llm-source + one LLM type-triage commit — the mergeable tip 1406 files, +183857 −186765 30 files, +66 −34 ✅ pass

@github-actions

github-actions Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Integration Test Results

14 tests   6 ✅  3s ⏱️
 1 suites  8 💤
 1 files    0 ❌

Results for commit 5ba6a48.

♻️ This comment has been updated with latest results.

This was referenced Apr 14, 2026
Open
Draft
Draft
Draft
Draft
Draft
Open
Draft
Merged
@keithharvey keithharvey mentioned this pull request Apr 15, 2026
Open
5 tasks
@keithharvey
keithharvey force-pushed the mig-busted-types branch 3 times, most recently from 32f8dca to 8dc58ed Compare April 16, 2026 22:06
@keithharvey keithharvey mentioned this pull request Apr 16, 2026
Open
@keithharvey
keithharvey force-pushed the mig-busted-types branch 4 times, most recently from 99717a3 to 835780b Compare April 22, 2026 18:12
@keithharvey
keithharvey force-pushed the mig-busted-types branch 2 times, most recently from 9f82944 to 4f8cb32 Compare April 24, 2026 16:39
@keithharvey
keithharvey changed the base branch from master to fmt April 24, 2026 16:40
@keithharvey
keithharvey marked this pull request as ready for review April 29, 2026 18:08
@keithharvey keithharvey mentioned this pull request Jul 9, 2026
Open
@keithharvey
gen(hand): inline luassert and busted LuaCATS types
5ba6a48 
Vendored LuaCATS annotations for busted/luassert to provide
IntelliSense for the unit-test surface. Lives on its own leaf so the
discussion around 'vendoring LuaCATS types' can happen in isolation —
prior pushback on the same direction in an earlier unit-testing PR
makes this the right place to litigate it rather than burying it in a
broader env commit.

Why vendored instead of declared as a Lux dep: Lux does not yet
support pulling LuaCATS annotations from library deps, and quick
attempts to wire this up in Lux failed. Upstream tracking issue:
lumen-oss/lux#953 — once that lands, these
directories should be deleted in favor of declaring busted as a
normal Lux dev-dep.

Sources (pinned SHAs):
  - types/busted/   https://github.com/LuaCATS/busted
                    @ 5ed85d0e016a5eb5eca097aa52905eedf1b180f1
  - types/luassert/ https://github.com/LuaCATS/luassert
                    @ d3528bb679302cbfdedefabb37064515ab95f7b9

See types/busted/provenance.md and types/luassert/provenance.md for
per-directory upstream refs + license status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@keithharvey